Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(index): add support for non-zero index types. #3104

Closed

Conversation

rzvxa
Copy link
Collaborator

@rzvxa rzvxa commented Apr 25, 2024

related to #3086 and #3092.

Adds support for this type of index definition:

oxc_index::define_index_type! {
    #[non_zero]
    pub struct NonZeroIdx8 = u8;
}

oxc_index::define_index_type! {
    #[non_zero]
    pub struct NonZeroIdx16 = u16;
}

oxc_index::define_index_type! {
    #[non_zero]
    pub struct NonZeroIdx32 = u32;
}

oxc_index::define_index_type! {
    #[non_zero]
    pub struct NonZeroIdxSz = usize;
}

Copy link
Collaborator Author

rzvxa commented Apr 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite Graphite

Copy link

codspeed-hq bot commented Apr 25, 2024

CodSpeed Performance Report

Merging #3104 will not alter performance

Comparing 04-25-feat_index_add_support_for_non-zero_index_types (9a6a567) with main (cd600fa)

Summary

✅ 30 untouched benchmarks

@rzvxa rzvxa force-pushed the 04-25-feat_index_add_support_for_non-zero_index_types branch from 61c1927 to 462a1fd Compare April 25, 2024 18:04
@rzvxa rzvxa added C-enhancement Category - New feature or request C-performance Category - Solution not expected to change functional behavior, only performance labels Apr 25, 2024
@rzvxa rzvxa force-pushed the 04-25-feat_index_add_support_for_non-zero_index_types branch from 7ab2857 to d2b0dfb Compare April 26, 2024 14:37
@rzvxa rzvxa closed this Apr 27, 2024
@rzvxa
Copy link
Collaborator Author

rzvxa commented Apr 27, 2024

Please don't delete this branch for now, I'm going to approach it at another time with a different method.

@Boshen Boshen deleted the 04-25-feat_index_add_support_for_non-zero_index_types branch August 12, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category - New feature or request C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant