refactor(linter): rewrite react/require-render-return

[mysteryven]

Closes: #3245

It's gone now, curious about why didn't have performance improvement.

This picture generated by running all the rules.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[mysteryven]

• refactor(linter): rewrite react/require-render-return #3276 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mysteryven and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #3276 will not alter performance

_{Comparing 05-14-refactor_linter_rewrite_react/require-render-return (db4ef3e) with main (a12ed0f)}

Summary

✅ 27 untouched benchmarks

[Boshen]

I don't get this ... https://github.com/jsx-eslint/eslint-plugin-react/blob/d97e3ed96afe77a56fdc6fc7bdec11c28bc256e2/lib/rules/require-render-return.js#L45-L47

Why does it need to save the component and then evaluate it on program exit?

[Boshen]

If we are inside the render method, are we able to find explicit returns through the control flow graph 🤔 ? Do you wanna playaround with the cfg and see if there's anything in it that could help?

[mysteryven]

After reviewing the hook rule, I have a poor concept of cfg, it will be fun to give it a try!