Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transformer): use UIDs for React imports #3431

Merged
merged 5 commits into from
May 29, 2024

Conversation

overlookmotel
Copy link
Collaborator

@overlookmotel overlookmotel commented May 27, 2024

Use UIDs for local var names for React JSX imports e.g. _jsx in import { jsx as _jsx } from "react/jsx-runtime";.

Copy link

graphite-app bot commented May 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label May 27, 2024
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@overlookmotel overlookmotel marked this pull request as ready for review May 27, 2024 12:02
Copy link

codspeed-hq bot commented May 27, 2024

CodSpeed Performance Report

Merging #3431 will not alter performance

Comparing 05-27-fix_transformer_use_uids_for_react_imports (6e769a8) with main (b188778)

Summary

✅ 22 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 05-27-fix_transformer_use_uids_for_react_imports branch from ca81cd6 to 4a5c430 Compare May 27, 2024 12:03
@Boshen Boshen requested a review from Dunqing May 27, 2024 12:53
@overlookmotel overlookmotel force-pushed the 05-27-fix_transformer_use_uids_for_react_imports branch from 4290857 to b4e1515 Compare May 28, 2024 21:33
@Dunqing Dunqing merged commit 90b0f6d into main May 29, 2024
25 checks passed
@Dunqing Dunqing deleted the 05-27-fix_transformer_use_uids_for_react_imports branch May 29, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants