refactor(typescript/namespace): reuse TSModuleBlock's scope id

[Dunqing]

No description provided.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[Dunqing]

• fix(transformer/typescript): variable declarations are not created when a function has a binding with the same name #3460
• refactor(typescript/namespace): reuse TSModuleBlock's scope id #3459 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #3459 will not alter performance

_{Comparing 05-29-refactor_typescript_namespace_reuse_tsmoduleblock_s_scope_id (1a50b86) with main (90b0f6d)}

Summary

✅ 22 untouched benchmarks

[Boshen]

merge conflict

[overlookmotel]

@Dunqing I've made some comments, but I don't fully understand TS namespaces. So feel free to ignore them and merge if you want.

Unless I'm understanding incorrectly, there should always be a TSModuleBlock we can get scope_id from unless the namespace is empty. And if the namespace is empty, we can exit from handle_nested early as the statement just gets deleted. Do I have that right?

If you like, merge this and then I'll have a go at fixing the "binding registered in wrong scope" problem I left unsolved previously, and you could check my work? Maybe that's easier than going back and forth with comments?

[Dunqing]

Unless I'm understanding incorrectly, there should always be a TSModuleBlock we can get scope_id from unless the namespace is empty. And if the namespace is empty, we can exit from handle_nested early as the statement just gets deleted. Do I have that right?

Yes. That's right.

If you like, merge this and then I'll have a go at fixing the "binding registered in wrong scope" problem I left unsolved previously, and you could check my work? Maybe that's easier than going back and forth with comments?

Sure!

[graphite-app]

Merge activity

• May 29, 6:53 PM EDT: Dunqing added this pull request to the Graphite merge queue.
• May 29, 7:05 PM EDT: Dunqing merged this pull request with the Graphite merge queue.