Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Added ecosystem check #574

Merged
merged 21 commits into from
Jul 21, 2023
Merged

CI: Added ecosystem check #574

merged 21 commits into from
Jul 21, 2023

Conversation

Leonard53
Copy link
Contributor

@Leonard53 Leonard53 commented Jul 19, 2023 •
edited
Loading

For issue #511
I have added an extra job to the existing Github Actions to ensure oxclint won't break real codebase.
The new job will clone microsoft/vscode, build oxlint under target/debug/oxclint, and run oxlint against the vsCode repo.

Boshen
Boshen reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me fix no-this-alias on main.

.rustc_info.json Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Boshen
Boshen reviewed Jul 20, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Boshen
Copy link
Member

Boshen commented Jul 20, 2023

You may rebase from the main branch, I fixed the severity on no-this-alias.

@github-actions github-actions bot added the A-linter Area - Linter label Jul 20, 2023
Leonard Yeung added 16 commits July 20, 2023 23:33
ci: added jobs to checkout vscode repo and run oxlint for ecosystem test
61c7c87
fix: ci clone directory pathing mistake
8e3edfd
fix: ci clone directory added back to prevent original repo deletion
d36a154
fix: typo on vscode directory
3ab3731
fix: build and use oxlint instead of using clippy
6b1bcf5
fix: removed build optimization to improve ci time, attempt to locate…
3333e81 
… binary file
refactor: removed accidental compiled blob
65cf874
fix: oxlint building path
0f97026
fix: oxlint run flag to ignore warning and follow vscode eslint confi…
99df7dc 
…g to avoid incorrect error thrown by the linter
fix: typo for flag and flag location
13941eb
refactor: removed accidental json file creation from rust compilation
bbb8cb1
refactor(ci): removed clippy requirement for ecosystem tests
02e6d49
refactor(ci): removed permission setting for cloned repo
cac293e
ci: added release flag when compiling oxlint during ecosystem test to…
bff628c 
… speed up linting
refactor(ci): changed actions name when checking out vscode branch in…
2ad9207 
… ecosystem tests
fix(ci): copmiled oxlint pathing after adding release flag
db45d65
@github-actions github-actions bot removed the A-linter Area - Linter label Jul 20, 2023
@Leonard53 Leonard53 marked this pull request as ready for review July 20, 2023 23:45
Boshen
Boshen approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's test this out and improve upon it. Thank you!

@Boshen Boshen merged commit 73338cb into oxc-project:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leonard53 @Boshen