Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): add no-extra-boolean-cast rule #677

Merged
merged 8 commits into from
Aug 4, 2023
Merged

feat(linter): add no-extra-boolean-cast rule #677

merged 8 commits into from
Aug 4, 2023

Conversation

metreniuk
Copy link
Contributor

Closes #596

Rule: Docs | Source | Tests

Notes:

  • All the tests are passing, didn't change or delete any of them.
  • I tried to mirror the source from Eslint and discovered some discrepancies in the AST. Looks like Eslint's AST doesn't consider a ParenthesizedExpression or Argument as separate nodes. Because of this I created the get_real_parent function.

@github-actions github-actions bot added the A-linter Area - Linter label Aug 1, 2023
Boshen
Boshen reviewed Aug 2, 2023
View reviewed changes
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Let's clean up the code a little bit.

crates/oxc_linter/src/rules/eslint/no_extra_boolean_cast.rs Outdated Show resolved Hide resolved
Boshen
Boshen approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for being patient with us!

@Boshen Boshen merged commit d1531cd into oxc-project:main Aug 4, 2023
20 checks passed
@metreniuk metreniuk deleted the lint/no-extra-boolean-cast branch August 4, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen approved these changes

@DonIsaac DonIsaac Awaiting requested review from DonIsaac

Assignees
No one assigned
Labels
A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(linter): eslint/no-extra-boolean-cast
3 participants
@metreniuk @Boshen @DonIsaac