Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): no-var-requires not warning if has bindings in ancestors #799

Merged
merged 4 commits into from
Aug 28, 2023

Conversation

mysteryven
Copy link
Member

image

@github-actions github-actions bot added the A-linter Area - Linter label Aug 27, 2023
@mysteryven mysteryven force-pushed the fix/no-var-require-in-ancestors branch from 8b63e32 to a8d7855 Compare August 27, 2023 16:07
@mysteryven mysteryven requested a review from Boshen August 27, 2023 23:40
@Boshen Boshen changed the title fix(linter): not warning if has bindings in ancestors fix(linter): no-var-requires not warning if has bindings in ancestors Aug 28, 2023
@Boshen Boshen merged commit 8b24052 into oxc-project:main Aug 28, 2023
16 checks passed
@mysteryven mysteryven deleted the fix/no-var-require-in-ancestors branch August 28, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants