Libquic integration #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LINK_LIBRARIES apparently isn't set for pure interface libraries, so we weren't picking up some needed libraries found via interface targets when building a bundled static lib; this fixes it by following INTERFACE_LINK_LIBRARIES when we recurse into an interface library.
• Updated to latest libQuic • Updated all C functions using 'wrap_exceptions' to return a bool
• Added code to calculate swarms locally instead of fetching • Stopped persisting the 'failure_count' to disk (it gets reset when refreshing the snode cache so why bother) • Stopped persisting the swarm cache to disk (it's now calculated locally so no need)
• Increased both upload and download min path counts from 1 to 2 • Added a new `PathSelectionBehaviour` which prioritises upload/download path selection based on which has the fewest pending requests • Fixed an issue where you could end up with paths with the same IP because the `unused_nodes` wasn't getting updated after building a path
• Fixed a bug and simplified the 'has_pending_requests' func • Tweaked logs to better distinguish between request ids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.