Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC updates for ed/x25519 keys #880

Closed
wants to merge 4 commits into from

Commits on Nov 8, 2019

  1. Add optional get_n_sns RPC request; remove get_all_sn_pubkeys RPC

    This allows a `"if_block_not_equal": "hash"` parameter to be given to
    `get_n_service_nodes` which, if the given value matches the current
    top block hash, skips building and returning a reply.
    
    This is primarily aimed at lokinet which polls fairly frequenty for an
    update but where the vast majority of those polls contain no new
    information.
    
    It also removes the get_all_service_nodes_public_keys RPC request
    completely as lokinet was the only consumer of it (particularly unlikely
    that anyone else was using this because it was returning the keys
    base32z-encoded).
    jagerman committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    f6bd747 View commit details
    Browse the repository at this point in the history
  2. Remove base32z encoding

    With the previous commit we no longer need this conversion (and lokinet
    is perfectly happy just getting hex encoded values instead).
    jagerman committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    5bde5a7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4591e28 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2019

  1. Rename fields & doc generation fixes

    Renamed:
      - `if_block_not_equal` -> `poll_block_hash`
      - `gave_if_not_equal` -> `polling_mode`
    
    Added lokidocs documentation for the new and existing get_n_service_node
    fields, and adds magic codes to disable the internal variables.
    jagerman committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    49c2bc3 View commit details
    Browse the repository at this point in the history