Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password Whitespace Elimation #1035

Merged
merged 7 commits into from
Apr 1, 2020
Merged

Password Whitespace Elimation #1035

merged 7 commits into from
Apr 1, 2020

Conversation

vincentbavitz
Copy link

Prevents users from setting or changing passwords which contain leading or trailing spaces

@vincentbavitz vincentbavitz changed the title Password Whitespace Elimation Password Whitespace Elimation & Typescript Upgrade Mar 31, 2020
@vincentbavitz vincentbavitz changed the title Password Whitespace Elimation & Typescript Upgrade Password Whitespace Elimation Apr 1, 2020
neuroscr
neuroscr approved these changes Apr 1, 2020
View reviewed changes
Copy link

@neuroscr neuroscr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not a fan of the timeout but doesn't sound like there's a better way

@vincentbavitz vincentbavitz merged commit 9dbfac3 into oxen-io:clearnet Apr 1, 2020
@vincentbavitz vincentbavitz deleted the password-whitespace branch April 1, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bilb Bilb Bilb approved these changes

@neuroscr neuroscr neuroscr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vincentbavitz @neuroscr @Bilb