Disable disappearing message before friend request accepted #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilb
force-pushed
the
disable-disappearing-message-set-before-friend
branch
from
7db2e61
to
9b6e82f
Compare
|
Are we removing nickname functionality? |
|
I think we should aim to keep the nickname functionality but fine with a temporary removal if it's not working yet. |
Bilb
force-pushed
the
disable-disappearing-message-set-before-friend
branch
from
9b6e82f
to
4a19e7d
Compare
Hide nickname option fron menu in ConversationHeader for now
Bilb
force-pushed
the
disable-disappearing-message-set-before-friend
branch
from
4a19e7d
to
796a371
Compare
Mikunj
approved these changes
Apr 2, 2020
neuroscr
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #963