Disappearing messages #2660

yougotwill · 2023-02-03T02:51:33Z

Updated right panel in a conversation to use overlay logic similar to the left panel.
Improved design for disappearing messages
Added panel radio buttons that are used for the disappearing message timer options
Improved Conversation Header that can switch between the notification settings, disappearing message setting and group members. When you click on the heading it opens the related right panel option (if available)
Added 2 new disappearing message modes (The original mode aka. Legacy will be removed in the future but will be kept for now for backwards compatibility / migration purposes)
1. Disappear After Read
2. Disappear After Send
Added disappearing support to other visible messages (call, group update, media extraction notifications etc.)
Use clock svg for disappearing countdown in all cases to keep in line with other platforms.
Disappearing messages are now correctly deleted from the swarm and won't appear when restoring a device
Users with newer desktop clients will get notified if they are sent messages from an older (legacy) client encouraging them to tell the other user to upgrade
Attachments should be correctly deleted off disk (and off swarm) once deleted in the client (solves Disappearing messages leave attachments on disk #2594, Attachment local deletion #2567)
Added a release feature utility which is used to activate a feature based on a set unix timestamp
Improved spacing and line height on toast notification

NOTE: Disappearing messages syncing will be finished after this branch is merged into the user config branch

ts/session/apis/snode_api/swarmPolling.ts

ts/session/messages/outgoing/ExpirableMessage.ts

ts/session/sending/MessageSentHandler.ts

ts/node/migration/sessionMigrations.ts

ts/session/apis/open_group_api/sogsv3/sogsV3ClearInbox.ts

ts/hooks/useParamSelector.ts

ts/models/message.ts

ts/session/messages/outgoing/visibleMessage/ClosedGroupVisibleMessage.ts

ts/state/ducks/conversations.ts

ts/util/releaseFeature.ts

…reparation for disappearing messages added panel buttons specific to this UI

… and xl margin option

added expirationType and lastDisappearingMessageChangeTimestamp to conversations table, left a few comments for future work

this is more explicit and allows use to use DisappearingMessageType in the message model

added to migration

…ated message pipeline this includes sync messages and updating the protobuf, haven't tested closed groups

updated copy for setting change messages

updated in parts but haven't test what happens

…ear after send

…ompatibility

improved setExpirationStartTimestamp logic

this prevents a clash with the userconfig properties to be merged in later

…el if there are no changes

ts/components/conversation/message/message-item/GroupInvitation.tsx

ts/components/conversation/message/message-item/GroupUpdateMessage.tsx

ts/components/conversation/message/message-item/notification-bubble/CallNotification.tsx

ts/components/conversation/right-panel/RightPanel.tsx

ts/components/conversation/right-panel/overlay/disappearing-messages/TimeOptions.tsx

Bilb · 2023-05-16T07:25:22Z

ts/state/selectors/conversations.ts

+  (convo: ReduxConversationType | undefined) => {
+    let modes = DisappearingMessageConversationSetting;
+    // TODO legacy messages support will be removed in a future release
+    // TODO remove legacy mode
+    modes = modes.slice(0, -1);
+
+    // Note to Self and Closed Groups only support deleteAfterSend
+    const isClosedGroup = convo?.isGroup && !convo.isPublic;
+    if (convo?.isMe || isClosedGroup) {
+      modes = [modes[0], modes[2]];
+    }


You could mark DisappearingMessageConversationSetting as const so typescript understands it's not just an array of random string.

I think those lines could maybe be

const modes = convo?.isMe || isClosedGroup ? [DisappearingMessageConversationSetting[0], DisappearingMessageConversationSetting[2] : DisappearingMessageConversationSetting.filter("legacy")

let's keep in like that until we remove the legacy support. I saw the next function has the same issues too

Cool cool. Yeah will be easier to cleanup later

ts/state/selectors/conversations.ts

ts/types/attachments/migrations.ts

fixed opening correct settings option depending on header option displayed

the previous logic relied on the length of the subtitles array which didn't account for when it changed depending on the conversation we were on

…eReadableMessage this stops us passing props down from the child components of ExpirableReadableMessage

…ting an attachment from disk

…e defined once

…o we have to make deleteData more robust javascript ¯\_(ツ)_/¯

…the default fixed session radio button flickering

converted scss toast styling to styled components

ts/components/conversation/right-panel/overlay/disappearing-messages/DisappearingModes.tsx

ts/util/releaseFeature.ts

ts/components/conversation/right-panel/overlay/disappearing-messages/TimeOptions.tsx

ts/components/conversation/header/ConversationHeaderTitle.tsx

ts/components/conversation/message/message-item/ExpirableReadableMessage.tsx

ts/components/conversation/header/ConversationHeaderSubtitle.tsx

since we need an id unaffected by localisation

… a string in react

yougotwill · 2023-10-03T06:21:58Z

Closed in favour of #2940

yougotwill force-pushed the disappearing_messages branch from f87f116 to d79fafa Compare February 13, 2023 05:31

yougotwill force-pushed the disappearing_messages branch from 7c7eacf to b91e170 Compare March 14, 2023 05:38

yougotwill force-pushed the disappearing_messages branch from 9f9ff59 to ee99205 Compare March 27, 2023 06:24

yougotwill force-pushed the disappearing_messages branch from 895da16 to a1c0930 Compare April 3, 2023 12:09

Bilb requested changes Apr 24, 2023

View reviewed changes

yougotwill added 25 commits April 26, 2023 11:41

feat: updated right panel in a conversation to use overlay logic in p…

8abd624

…reparation for disappearing messages added panel buttons specific to this UI

feat: added panel radio buttons that list timer options

a42aff3

fix: rebuilt disappearing messages header beause syncthing

46a8801

feat: added panel label for timer options

6b06e4a

feat: made right panel scrollable, added subtitle to panelradiobutton…

ecfd69f

… and xl margin option

feat: added basic support for different disappearing message modes

30196a1

added expirationType and lastDisappearingMessageChangeTimestamp to conversations table, left a few comments for future work

feat: removed DisappearingMessageMenuItem from conversation context menu

c8a13e1

fix: make sure to update state when the covnersation changes

f4e5d89

fix: improved migration queries

976cb2a

feat: DisappearingMessageType -> DisappearingMessageConversationType

b12d086

this is more explicit and allows use to use DisappearingMessageType in the message model

feat: added expirationType to message model with correct typings

1303707

added to migration

fix: moved disappearing message types to utils

0700ac4

feat: added expirationType and expireTimer to content message and upd…

ee6607b

…ated message pipeline this includes sync messages and updating the protobuf, haven't tested closed groups

fix: correctly write to db when setting changes

2745571

feat: added default timer values for different modes

4731139

feat: control available modes depending on the conversation

8dc7dac

feat: added function for calculating the expire start time

13f091e

updated copy for setting change messages

feat: started consolidating send and receive dm logic.

22e0263

updated in parts but haven't test what happens

feat: disappearing after send is not working correctly

ee4aa33

feat: attempted to improve the accuracy of the start timer for disapp…

4ee4403

…ear after send

feat: disappear after reading now works

6febf28

feat: slight improved timing of sent message expire start time

4d92500

feat: improved syncing of timers for disappear after send

996d204

fix: prevent duplicate expire timer updates while keeping backwards c…

b4fc33c

…ompatibility

feat: fixed closed groups

d358ab2

improved setExpirationStartTimestamp logic

yougotwill added 4 commits May 9, 2023 11:52

fix: updated disappearing messages protobuf content values

a9f4cd3

this prevents a clash with the userconfig properties to be merged in later

fix: run expireUpdate handler on all messages and just return the mod…

c6cd367

…el if there are no changes

feat: comment out development timer options

9a7a890

feat: added PropsForExpirationSettings type

96ae508

Bilb requested changes May 17, 2023

View reviewed changes

yougotwill added 11 commits May 17, 2023 14:08

fix: added onclick function to subtitle

8c345ce

fixed opening correct settings option depending on header option displayed

feat: added data test ids

a1a3d68

feat: improved robustness of changing the conversation header subtitle

a10822b

the previous logic relied on the length of the subtitles array which didn't account for when it changed depending on the conversation we were on

fix: remove panel-settings panel mode since it is not needed

dd40fba

feat: created getMessageExpirationProps selector and used in Expirabl…

5d4238a

…eReadableMessage this stops us passing props down from the child components of ExpirableReadableMessage

fix: cleanup comments

df27fa1

fix: reverted code and updated comment on readReceipts pending qa

b601c11

fix: incorrect direction check in getPropsForExpiringMessage

959fb66

feat: added DisappearingMessageModesWithState type

73ca994

feat: print error message and not entire error if available when dele…

c1ea1f0

…ting an attachment from disk

fix: check if path is undefined first in deleteData function

220d9bf

yougotwill changed the title ~~[WIP] Disappearing messages~~ Disappearing messages May 18, 2023

yougotwill added 4 commits May 19, 2023 13:46

fix: moved feature release timestamp to constants so it only has to b…

f41c28a

…e defined once

fix: converting undefined to a string does not make an empty string s…

c953c9f

…o we have to make deleteData more robust javascript ¯\_(ツ)_/¯

feat: make timer value load an existing one from the conversation or …

8fb3f26

…the default fixed session radio button flickering

feat: improved spacing on toast notification

98b93b1

converted scss toast styling to styled components

Bilb reviewed May 22, 2023

View reviewed changes

yougotwill added 4 commits May 22, 2023 16:26

fix: disappearing modes loadDataTestId should return in switch cases

996f1d0

fix: changed timer options dataTestId to use seconds and not the name

5cd4bf1

since we need an id unaffected by localisation

fix: checking the subtitle array without casting as bool will produce…

2fbee21

… a string in react

fix: mispell of ConversationHeaderSubtitle

992d3d3

Bilb approved these changes May 23, 2023

View reviewed changes

KeeJef mentioned this pull request Sep 13, 2023

Manually deleted chats and messages gets restored when linking / recovery #1887

Closed

yougotwill closed this Oct 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disappearing messages #2660

Disappearing messages #2660

yougotwill commented Feb 3, 2023 •

edited

Loading

Bilb May 16, 2023

Bilb May 16, 2023

yougotwill May 18, 2023

yougotwill commented Oct 3, 2023

Disappearing messages #2660

Disappearing messages #2660

Conversation

yougotwill commented Feb 3, 2023 • edited Loading

Bilb May 16, 2023

Choose a reason for hiding this comment

Bilb May 16, 2023

Choose a reason for hiding this comment

yougotwill May 18, 2023

Choose a reason for hiding this comment

yougotwill commented Oct 3, 2023

yougotwill commented Feb 3, 2023 •

edited

Loading