forked from signalapp/Signal-Desktop
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add setting to follow system theming #2957
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: check theme congruence on startup and on native theme update fix: make toggle and startup following work fix: should return here, but this breaks things
KeeJef
force-pushed
the
follow-system-theme
branch
from
October 20, 2023 03:40
d33aa0d
to
2fe29ca
Compare
KeeJef
changed the title
WIP feat: Add setting to follow system theming
feat: Add setting to follow system theming
Oct 20, 2023
Bilb
requested changes
Oct 22, 2023
Bilb
reviewed
Oct 29, 2023
Looks good |
Fix conflict merge issue fix: missing bracket
KeeJef
force-pushed
the
follow-system-theme
branch
from
November 14, 2023 02:50
6e45716
to
939f8ca
Compare
Bilb
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing #1328