Disappearing message rebuild #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanRory
changed the title
RyanRory
changed the title
mpretty-cyro
requested changes
Dec 19, 2022
There was a problem hiding this comment.
- We are looking to discuss some potential changes to the tech design as the updated user config handling might be able to be completed before this goes live so before running through these issues it might be good to touch base as there may be more/less work to do 😉
SessionMessagingKit/Database/Migrations/_003_YDBToGRDBMigration.swift
Outdated
Show resolved
Hide resolved
RyanRory
changed the title
…-redesign # Conflicts: # Session.xcodeproj/project.pbxproj # Session/Conversations/Settings/ThreadDisappearingMessagesViewModel.swift # Session/Shared/Views/SessionCell+AccessoryView.swift # SessionMessagingKit/Configuration.swift # SessionMessagingKit/Database/Models/Interaction.swift # SessionMessagingKit/Shared Models/SessionThreadViewModel.swift # SessionUtilitiesKit/Database/Models/Job.swift
mpretty-cyro
reviewed
May 9, 2023
| interactionExpirationInfosByExpiresInSeconds.forEach { expiresInSeconds, expirationInfos in | ||
| let expirationTimestampMs: Int64 = Int64(ceil(startedAtMs + expiresInSeconds * 1000)) | ||
|
|
||
| SnodeAPI.updateExpiry( |
There was a problem hiding this comment.
What happens if the app closes before these succeed?
| openGroupServerMessageId: message.openGroupServerMessageId.map { Int64($0) } | ||
| ).update(db) | ||
| // Only store the server hash of a sync message if the message is self send valid | ||
| if (message.isSelfSendValid && isSyncMessage || !message.isSelfSendValid) { |
There was a problem hiding this comment.
This was causing an issue where open group DMs were appearing twice (because it was failing this check) - I updated the check to the below but you should probably test and make sure the logic is what you were after:
if (message.isSelfSendValid && isSyncMessage || !isSyncMessage)
…ling' into disappearing-message-redesign # Conflicts: # Session.xcodeproj/project.pbxproj # Session/Conversations/ConversationVC.swift # Session/Conversations/ConversationViewModel.swift # Session/Conversations/Settings/ThreadDisappearingMessagesSettingsViewModel.swift # Session/Conversations/Settings/ThreadSettingsViewModel.swift # Session/Conversations/Views & Modals/ConversationTitleView.swift # Session/Notifications/AppNotifications.swift # Session/Settings/NukeDataModal.swift # Session/Shared/SessionTableViewModel.swift # Session/Shared/Views/SessionCell.swift # SessionMessagingKit/Configuration.swift # SessionMessagingKit/Database/Models/Contact.swift # SessionMessagingKit/Database/Models/DisappearingMessageConfiguration.swift # SessionMessagingKit/Messages/Control Messages/ClosedGroupControlMessage.swift # SessionMessagingKit/Messages/Message.swift # SessionMessagingKit/Messages/Visible Messages/VisibleMessage.swift # SessionMessagingKit/Protos/Generated/SNProto.swift # SessionMessagingKit/Protos/Generated/SessionProtos.pb.swift # SessionMessagingKit/Protos/SessionProtos.proto # SessionMessagingKit/Sending & Receiving/Message Handling/MessageReceiver+ExpirationTimers.swift # SessionMessagingKit/Sending & Receiving/MessageReceiver.swift # SessionMessagingKit/Shared Models/SessionThreadViewModel.swift # SessionMessagingKitTests/Open Groups/OpenGroupManagerSpec.swift # SessionMessagingKitTests/_TestUtilities/TestOnionRequestAPI.swift # SessionSnodeKit/Models/SnodeAPIEndpoint.swift # SessionSnodeKit/SnodeAPI.swift # SessionTests/Conversations/Settings/ThreadDisappearingMessagesViewModelSpec.swift # SessionUtilitiesKit/General/Features.swift
…-message-redesign
….com/mpretty-cyro/session-ios into disappearing-message-redesign
…oved immediately.
…1D default setting
…-redesign # Conflicts: # .drone.jsonnet
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #731 +/- ##
==========================================
+ Coverage 11.43% 11.44% +0.01%
==========================================
Files 633 643 +10
Lines 95960 98320 +2360
==========================================
+ Hits 10970 11253 +283
- Misses 84990 87067 +2077 ☔ View full report in Codecov by Sentry. |
…anRory/loki-messenger-ios into disappearing-message-redesign
…synced on new linked devices
…oved by a race condition
…essages received by PNs.
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.