Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pulumi eks to 0.41.0 #19

Merged
merged 4 commits into from
Jun 23, 2022
Merged

update pulumi eks to 0.41.0 #19

merged 4 commits into from
Jun 23, 2022

Conversation

orcutt989
Copy link
Contributor

@orcutt989 orcutt989 commented Jun 23, 2022

AWS updated Kubernetes on EKS to 1.22 a few months ago

This broke the api version when deploying the vpc-cni with pulumi.

error: unable to recognize "/tmp/tmp-533062KrWi6df0QCqN.tmp": no matches for kind "CustomResourceDefinition" in version "apiextensions.k8s.io/v1beta1"

A similar issue described here
https://github.com/pulumi/pulumi-eks/blob/cc78896f6453516b0c406064652557f52813cf1e/nodejs/eks/cni/aws-k8s-cni.yaml#L202

Updating pulumi-eks to 0.41.0 fixes the above issue.

Which then results in the following error if your kubectl is a lower version.

 Error: At least v1.24.0 of kubectl is required. Current version is: 1.23.8. See https://kubernetes.io/docs/tasks/tools/install-kubectl/#install-kubectl for instructions on installing the latest.

Updating kubectl resolves this so maybe a disclaimer about that might be good somewhere.

@harryttd
Copy link
Collaborator

Thank you for debugging this Jimmy.

When updating a package it needs to be done through the package manager. Not manually changing the version in package.json.

Without this the lock file and the package versions are conflicting.

@orcutt989
Copy link
Contributor Author

orcutt989 commented Jun 23, 2022

Thank you for debugging this Jimmy.

When updating a package it needs to be done through the package manager. Not manually changing the version in package.json.

Without this the lock file and the package versions are conflicting.

Thanks @harryttd. I noticed there wasn't a package.lock.json so I opted to only update package.json, but I see there is a yarn.lock. I installed with npm install @pulumi/eks. I just pushed and it now there is package.lock.json. Do we want that new file?

@orcutt989 orcutt989 changed the title update pulumi eks to 0.44.0 update pulumi eks to 0.41.0 Jun 23, 2022
@harryttd
Copy link
Collaborator

The package manager being used in this project is yarn, not npm. Only yarn commands should be used, and updating the package will update the lock file. There should only be a package-lock.json file in an npm project. We also want to keep the version exact and not with ^. That can cause incompatibility issues when people install our module and they get a newly released version of a package which could potentially break it (this is the approach i took for now in this project but may change it).

@harryttd
Copy link
Collaborator

You can run yarn upgrade @pulumi/eks@0.41.0 and there should be minimal changes. I will later on run an upgrade on all packages and test if anything breaks.

@orcutt989
Copy link
Contributor Author

You can run yarn upgrade @pulumi/eks@0.41.0 and there should be minimal changes. I will later on run an upgrade on all packages and test if anything breaks.

Thanks @harryttd . How does this look now?

@harryttd
Copy link
Collaborator

It's still not pinned

see my comment:

You can run yarn upgrade @pulumi/eks@0.41.0 and there should be minimal changes. I will later on run an upgrade on all packages and test if anything breaks.

@orcutt989 orcutt989 closed this Jun 23, 2022
@orcutt989 orcutt989 reopened this Jun 23, 2022
@orcutt989
Copy link
Contributor Author

It's still not pinned

see my comment:

You can run yarn upgrade @pulumi/eks@0.41.0 and there should be minimal changes. I will later on run an upgrade on all packages and test if anything breaks.

Ah I thought a caret ^ meant a pin! I got it now! Thanks!

@harryttd
Copy link
Collaborator

Thank you. Please squash.

I'm not going to release yet. But for Daniel, he can just install the version he needs on his own in his project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants