Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow udprpc to send Jefe.request_reset #1295

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Conversation

jgallagher
Copy link
Contributor

Prior to this PR, attempting to call Jefe.request_reset via udprpc would time out:

% cargo xtask humility app/gimletlet/app.toml  -- --ip fe80::0c1d:7dff:feef:9f1d%eth0 hiffy -c Jefe.request_reset
    Finished dev [optimized + debuginfo] target(s) in 0.21s
     Running `target/debug/xtask humility app/gimletlet/app.toml -- --ip 'fe80::0c1d:7dff:feef:9f1d%eth0' hiffy -c Jefe.request_reset`
humility: connecting to fe80::0c1d:7dff:feef:9f1d%eth0
humility hiffy failed: Resource temporarily unavailable (os error 11)
Error: humility failed

because jefe returned an access violation:

14 udprpc                       1   6 FAULT: reply fault: task id #0/gen0, reason AccessViolation (was: wait: reply from jefe/gen0)

After this PR, attempting to call Jefe.request_reset via udprpc still times out from humility's point of view, but because the SP has actually reset and therefore does not respond to the request.

@jgallagher jgallagher requested a review from mkeeter April 18, 2023 17:56
@jgallagher
Copy link
Contributor Author

This isn't the full support requested in #1290 but is better than nothing, I think.

@jgallagher jgallagher merged commit 6fbfab4 into master Apr 18, 2023
@jgallagher jgallagher deleted the allow-udprpc-request-reset branch April 18, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants