Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hiffy:: Add SendLeaseReadWrite idol function. #1587

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

flihp
Copy link
Contributor

@flihp flihp commented Jan 9, 2024

This function is called by humility hiffy to call hif operations that require a read and a write lease.

@flihp
Copy link
Contributor Author

flihp commented Jan 9, 2024

I'll post a link to the matching PR in humility where this new hif function is called when it's up.

@flihp
Copy link
Contributor Author

flihp commented Jan 9, 2024

looks like adding this function to the send feature on the g0 / donglet rolled over 8k flash :( Working on putting this new function behind a feature flag as a quick fix. Depending on how bad the code size issue is it may be something we can get back under 8k. I'll likely leave this as future work since the g0 doesn't need this feature currently.

This function is called by `humility hiffy` to call hif operations that
require a read and a write lease. This commit hides this function behind
a new feature `send-rw` because including it in the existing `send`
feature causes the `hiffy` task in g0 images to roll over into another
flash block that isn't available on the donglet images. This new feature
is enabled by the existing `lpc55` and `stm32h7` features making this
mosly transparent to the app.tomls.
@flihp
Copy link
Contributor Author

flihp commented Jan 9, 2024

Copy link
Collaborator

@labbott labbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flihp flihp merged commit dc95c25 into oxidecomputer:master Jan 11, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants