Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/net: import design doc from gist #1603

Merged
merged 2 commits into from
Jan 31, 2024
Merged

task/net: import design doc from gist #1603

merged 2 commits into from
Jan 31, 2024

Conversation

cbiffle
Copy link
Collaborator

@cbiffle cbiffle commented Jan 30, 2024

Forgot to actually check this in, whoops.

Forgot to actually check this in, whoops.
@cbiffle cbiffle requested review from mkeeter and hawkw January 30, 2024 21:23
@cbiffle cbiffle enabled auto-merge (rebase) January 30, 2024 21:23
task/net/README.md Outdated Show resolved Hide resolved
task/net/README.md Outdated Show resolved Hide resolved
task/net/README.md Outdated Show resolved Hide resolved
task/net/README.md Outdated Show resolved Hide resolved
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is lovely! I commented on a couple very tiny copyedits, but the documentation itself is clear and easy to follow.

task/net/README.md Outdated Show resolved Hide resolved
task/net/README.md Outdated Show resolved Hide resolved
task/net/README.md Outdated Show resolved Hide resolved
@cbiffle
Copy link
Collaborator Author

cbiffle commented Jan 31, 2024

Thanks folks, changes applied, PTAL.

@cbiffle cbiffle merged commit 2f5bc53 into master Jan 31, 2024
77 checks passed
@cbiffle cbiffle deleted the netstack-docs branch January 31, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants