Yo dawg i heard you like ringbufs #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These modules were importing ringbuf_entry_root as ringbuf_entry, which was super confusing because ringbuf_entry has features that ringbuf_entry_root doesn't pass through! So there I was attempting to use ringbuf_entry! and getting inexplicable compile failures. I don't think saving five characters is worth that.
Whoever added the _root variant deliberately left out support for named ringbufs. No idea why. Fixed.
cbiffle
force-pushed
the
yo-dawg-i-heard-you-like-ringbufs
branch
2 times, most recently
from
895245f
to
d92e965
Compare
jgallagher
approved these changes
Feb 15, 2024
Our ability to debug #1613 was hampered by the control-plane-agent ringbuf being overwritten, on average, every 1.5 seconds. This adds a secondary ringbuf that only holds "important" events -- specifically, commands received from the network that affect the host. Unfortunately due to the BSP structure in the agent right now, this required copy-pasting a change into three files. Fixing that appears difficult. Fixes #1615.
cbiffle
force-pushed
the
yo-dawg-i-heard-you-like-ringbufs
branch
from
d92e965
to
2451d90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final commit is the relevant one, description copied below. The other two commits are cleanups on the way there.
Our ability to debug #1613 was hampered by the control-plane-agent
ringbuf being overwritten, on average, every 1.5 seconds. This adds a
secondary ringbuf that only holds "important" events -- specifically,
commands received from the network that affect the host.
Unfortunately due to the BSP structure in the agent right now, this
required copy-pasting a change into three files. Fixing that appears
difficult.