Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jefe: add counters to Jefe's ringbufs #1636

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

hawkw
Copy link
Member

@hawkw hawkw commented Feb 28, 2024

Currently, Jefe has a few ringbufs that are quite small. This means that events may drop off the back of these ringbuffers. This commit updates these ringbufs to also count events, so that we can track the total number of times that various things have happened in Jefe.

Currently, Jefe has a few ringbufs that are quite small. This means that
events may drop off the back of these ringbuffers. This commit updates
these ringbufs to also count events, so that we can track the total
number of times that various things have happened in Jefe.
@hawkw hawkw self-assigned this Feb 28, 2024
@hawkw hawkw marked this pull request as ready for review February 28, 2024 20:59
@hawkw
Copy link
Member Author

hawkw commented Feb 28, 2024

I also thought about adding a counter for each IPC request variant, but adding an additional ringbuf (so that we can record the requesting task's ID for the last few IPCs) ends up making the Jefe task quite a bit bigger, which seemed unfortunate. If recording IPCs is something that's actually useful here, I can add that, either as a ringbuf + counters, or just counters without the requester's ID, depending on which seems more useful (and whether the increased memory is worth it).

@hawkw
Copy link
Member Author

hawkw commented Mar 25, 2024

I also thought about adding a counter for each IPC request variant, but adding an additional ringbuf (so that we can record the requesting task's ID for the last few IPCs) ends up making the Jefe task quite a bit bigger, which seemed unfortunate. If recording IPCs is something that's actually useful here, I can add that, either as a ringbuf + counters, or just counters without the requester's ID, depending on which seems more useful (and whether the increased memory is worth it).

Update: Counting IPC requests is now mostly obsoleted by client-side IPC interface counters in jefe-api (added in #1642). The error counters in this branch are probably still desirable though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant