I2C: trace IRQ status on panic #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IIUC the notification mask for a controller should only ever be one-hot, so the for loop isn't necessary.
hawkw
commented
Mar 19, 2024
Comment on lines
+206
to
208
| #[count(skip)] | ||
| Panic(Register, u32), | ||
| #[count(skip)] |
There was a problem hiding this comment.
I added #[count(skip)] to the ringbuf entries that are only recorded on panics, since we don't really care about counting them --- they'll either be counted exactly the number of times we record them in the panic code, or they'll never be recorded at all. So, I figured it was worth saving the 8 bytes we can shave off by not generating counters for these.
hawkw
commented
Mar 19, 2024
| @@ -37,7 +37,6 @@ name = "drv-stm32xx-i2c-server" | |||
| stacksize = 1048 | |||
| features = ["h743"] | |||
| priority = 2 | |||
| max-sizes = {flash = 16384, ram = 4096} | |||
There was a problem hiding this comment.
We hit the flash size limit for the I2C server task, and @cbiffle said it would be fine to just remove the limits so that we don't have to keep playing guess-a-number forever.
cbiffle
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
irq_statussystem call I added in #1661, we can extend thepanic function added to
stm32xx-i2cin #1657 to also include the stateof any IRQs currently mapped to its notification mask. This way, if an
I2C driver panics, we can also include the kernel's understanding of its
IRQ state in the dump.