stm32h7: merge eth and eth_dma MPU regions
#1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the stm32h7 chip config defines two separate MPU regions for the Ethernet peripheral, `eth` and `eth_dma`. But, these regions are contiguous in memory. So, we can combine them into one region and get an entire MPU slot back, which seems nice.
mkeeter
approved these changes
Mar 20, 2024
eliza@theseus $ humility net ip
humility: attached via ST-Link V3
MAC address: 0e:1d:de:f0:d9:21
IPv6 address: fe80::0c1d:deff:fef0:d921
eliza@theseus $ ping fe80::0c1d:deff:fef0:d921%eth0
PING fe80::0c1d:deff:fef0:d921%eth0 (fe80::c1d:deff:fef0:d921%eth0) 56 data bytes
64 bytes from fe80::c1d:deff:fef0:d921%eth0: icmp_seq=2 ttl=64 time=0.219 ms
64 bytes from fe80::c1d:deff:fef0:d921%eth0: icmp_seq=3 ttl=64 time=0.233 ms
64 bytes from fe80::c1d:deff:fef0:d921%eth0: icmp_seq=4 ttl=64 time=0.238 ms
64 bytes from fe80::c1d:deff:fef0:d921%eth0: icmp_seq=5 ttl=64 time=0.250 ms
64 bytes from fe80::c1d:deff:fef0:d921%eth0: icmp_seq=6 ttl=64 time=0.354 ms
64 bytes from fe80::c1d:deff:fef0:d921%eth0: icmp_seq=7 ttl=64 time=0.284 ms
64 bytes from fe80::c1d:deff:fef0:d921%eth0: icmp_seq=8 ttl=64 time=0.315 ms
^X64 bytes from fe80::c1d:deff:fef0:d921%eth0: icmp_seq=9 ttl=64 time=0.228 ms
^C
--- fe80::0c1d:deff:fef0:d921%eth0 ping statistics ---
9 packets transmitted, 8 received, 11.1111% packet loss, time 8211ms
rtt min/avg/max/mdev = 0.219/0.265/0.354/0.045 ms
|
|
haha cool CI failure appears to be downloading humility, will rerun: https://github.com/oxidecomputer/hubris/actions/runs/8364354965/job/22899505454?pr=1669 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the stm32h7 chip config defines two separate MPU regions for the Ethernet peripheral,
ethandeth_dma. But, these regions are contiguous in memory. So, we can combine them into one region and get an entire MPU slot back, which seems nice.