Disable smart packing #1671
Merged
Disable smart packing #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeter
force-pushed
the
disable-smart-packing
branch
from
73d9717
to
9c5c146
Compare
hawkw
approved these changes
Mar 20, 2024
cbiffle
approved these changes
Mar 20, 2024
hawkw
added a commit
that referenced
this pull request
Mar 20, 2024
This unbreaks the donglet build for now, after disabling autopacking in #1671 made it too big.
hawkw
added a commit
that referenced
this pull request
Mar 20, 2024
This unbreaks the donglet build for now, after disabling autopacking in #1671 made it too big.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel will reject leases that span multiple regions, so this PR disables smart packing entirely by forcing each task's flash into a single MPU region (just like before #1599). Otherwise, tasks which loan out their flash memory may produce spurious faults.