Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

power: add comments to gimlet rail sag trace facility #1687

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

cbiffle
Copy link
Collaborator

@cbiffle cbiffle commented Mar 28, 2024

This should help avoid the situation where someone unknowingly removes or modifies this in a way that breaks racktest.

Copy link

@jordanhendricks jordanhendricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, Cliff!

I'm not sure what the Hubris policy is on leaving TODOs in PRs, but the comments look good to me. Much appreciated.

This should help avoid the situation where someone unknowingly removes
or modifies this in a way that breaks racktest.
@cbiffle cbiffle force-pushed the cbiffle/max5970-trace-comments branch from ddfad77 to 6c6cc71 Compare April 1, 2024 16:40
@cbiffle cbiffle merged commit 71d05a3 into master Apr 1, 2024
103 checks passed
@cbiffle cbiffle deleted the cbiffle/max5970-trace-comments branch April 1, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants