sensor: remove noop 1 Hz timer #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbiffle
commented
Apr 1, 2024
|
|
||
| // N.B. if you are staring at this macro thinking that it looks like it | ||
| // doesn't do anything and might be obsolescent, the key is the :upper. This | ||
| // macro exists exclusively to uppercase the field names below. |
There was a problem hiding this comment.
(this macro confused me so I tossed in this documentation of it while I was here.)
cbiffle
force-pushed
the
cbiffle/remove-noop-sensor-timer
branch
2 times, most recently
from
9569fc6
to
6637e13
Compare
hawkw
approved these changes
Apr 2, 2024
bcantrill
approved these changes
Apr 2, 2024
task/sensor was configuring a timer to wake it every 1 Hz. Each time it woke up, it would snooze its alarm clock and go back to sleep. While I definitely sympathize with that desire, this is essentially dead code that looks like a bug, so this commit removes it. I'm not sure what the history here is. In addition to removing noise from the code, this knocks 114 bytes off the sensor task text size.
cbiffle
force-pushed
the
cbiffle/remove-noop-sensor-timer
branch
from
6637e13
to
2e24fbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task/sensor was configuring a timer to wake it every 1 Hz. Each time it woke up, it would snooze its alarm clock and go back to sleep.
While I definitely sympathize with that desire, this is essentially dead code that looks like a bug, so this commit removes it. I'm not sure what the history here is.
In addition to removing noise from the code, this knocks 114 bytes off the sensor task text size.