thermal: remove panic formatting and Debug impls
#1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `thermal` task uses `unwrap()` in a bunch of places,
requiring it to derive `Debug` for a bunch of stuff. This commit changes
those to `unwrap_lite()`, and removes many of the derived `Debug` impls.
On `gimlet-f`, this shaves off about 1K of flash:
before:
```
thermal flash 23316 23328 32768
ram 7820 8192 8192
```
after:
```
thermal flash 22392 22400 32768
ram 7820 8192 8192
```
It would be nice to also remove the derived `Debug` from types like
`SensorId`, but it looks like that's currently used by `validate_api`
--- I wasn't sure if any of the `validate_api` types are used in
control-plane comms, so I didn't touch that yet. May do so in a
follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
thermaltask usesunwrap()in a bunch of places,requiring it to derive
Debugfor a bunch of stuff. This commit changesthose to
unwrap_lite(), and removes many of the derivedDebugimpls.On
gimlet-f, this shaves off about 1K of flash:before:
after:
It would be nice to also remove the derived
Debugfrom types likeSensorId, but it looks like that's currently used byvalidate_api--- I wasn't sure if any of the
validate_apitypes are used incontrol-plane comms, so I didn't touch that yet. May do so in a
follow-up.