You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After running into a mistake where we converted a raw IP into a /128 (when it should have been a /56), fixed in #5668, we filed an upstream request (achanda/ipnetwork#190) to remove the From impl to discourage accidental misuse by requiring a more explicit constructor. I just noticed we also have an IpNet type that implements these same conversions:
(and the subsequent conversions from Ipv6Addr and IpAddr a little below that). We should also remove these and provide explicit constructors instead, I think.
The text was updated successfully, but these errors were encountered:
After running into a mistake where we converted a raw IP into a
/128
(when it should have been a /56), fixed in #5668, we filed an upstream request (achanda/ipnetwork#190) to remove theFrom
impl to discourage accidental misuse by requiring a more explicit constructor. I just noticed we also have anIpNet
type that implements these same conversions:omicron/common/src/api/external/mod.rs
Lines 1451 to 1455 in 50cd41c
Ipv6Addr
andIpAddr
a little below that). We should also remove these and provide explicit constructors instead, I think.The text was updated successfully, but these errors were encountered: