[nexus-types] use TypedUuid<SledKind> in blueprint-internal code #5488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
3 tasks
jgallagher
approved these changes
Apr 10, 2024
| // Temporarily make a clone of the parent blueprint's zones so we can use | ||
| // typed UUIDs everywhere. Once we're done migrating, this `Cow` can be | ||
| // removed. | ||
| parent_zones: Cow<'a, BTreeMap<TypedUuid<SledKind>, BlueprintZonesConfig>>, |
There was a problem hiding this comment.
Just making sure I understand: the Cow is technically unnecessary (we always construct it as Cow::Owned), but is just here as a hint to remind us to switch it back to &'a BTreeMap<...>?
There was a problem hiding this comment.
Right, exactly. This is a temporary situation.
sunshowers
deleted the
sunshowers/spr/nexus-types-use-typeduuidsledkind-in-blueprint-internal-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most APIs aren't changing, nor is the OpenAPI schema for now -- just code
internal to the blueprint.