[reconfigurator] Decommission sleds

dev-tools/omdb/src/bin/omdb/db.rs

@@ -1455,8 +1455,11 @@ async fn cmd_db_sleds(
     let filter = match args.filter {
         Some(filter) => filter,
         None => {
-            eprintln!("note: listing all sleds (use -F to filter, e.g. -F in-service)");
-            SledFilter::All
+            eprintln!(
+                "note: listing all commissioned sleds \
+                 (use -F to filter, e.g. -F in-service)"
+            );
+            SledFilter::Commissioned
         }
     };
 

dev-tools/omdb/tests/env.out

@@ -9,7 +9,7 @@ stdout:
 stderr:
 note: using database URL postgresql://root@[::1]:REDACTED_PORT/omicron?sslmode=disable
 note: database schema version matches expected (<redacted database version>)
-note: listing all sleds (use -F to filter, e.g. -F in-service)
+note: listing all commissioned sleds (use -F to filter, e.g. -F in-service)
 =============================================
 EXECUTING COMMAND: omdb ["db", "--db-url", "junk", "sleds"]
 termination: Exited(2)
@@ -341,7 +341,7 @@ note: database URL not specified.  Will search DNS.
 note: (override with --db-url or OMDB_DB_URL)
 note: using database URL postgresql://root@[::1]:REDACTED_PORT/omicron?sslmode=disable
 note: database schema version matches expected (<redacted database version>)
-note: listing all sleds (use -F to filter, e.g. -F in-service)
+note: listing all commissioned sleds (use -F to filter, e.g. -F in-service)
 =============================================
 EXECUTING COMMAND: omdb ["--dns-server", "[::1]:REDACTED_PORT", "db", "sleds"]
 termination: Exited(0)
@@ -356,5 +356,5 @@ note: database URL not specified.  Will search DNS.
 note: (override with --db-url or OMDB_DB_URL)
 note: using database URL postgresql://root@[::1]:REDACTED_PORT/omicron?sslmode=disable
 note: database schema version matches expected (<redacted database version>)
-note: listing all sleds (use -F to filter, e.g. -F in-service)
+note: listing all commissioned sleds (use -F to filter, e.g. -F in-service)
 =============================================

dev-tools/omdb/tests/successes.out

@@ -80,7 +80,7 @@ stdout:
 stderr:
 note: using database URL postgresql://root@[::1]:REDACTED_PORT/omicron?sslmode=disable
 note: database schema version matches expected (<redacted database version>)
-note: listing all sleds (use -F to filter, e.g. -F in-service)
+note: listing all commissioned sleds (use -F to filter, e.g. -F in-service)
 =============================================
 EXECUTING COMMAND: omdb ["db", "sleds", "-F", "discretionary"]
 termination: Exited(0)

dev-tools/omdb/tests/test_all_output.rs

@@ -165,7 +165,7 @@ async fn test_omdb_success_cases(cptestctx: &ControlPlaneTestContext) {
     // collection?
     assert!(parsed
         .planning_input
-        .all_sled_ids(SledFilter::All)
+        .all_sled_ids(SledFilter::Commissioned)
         .next()
         .is_some());
     assert!(!parsed.collections.is_empty());

dev-tools/omdb/tests/usage_errors.out

@@ -226,7 +226,7 @@ Options:
           Show sleds that match the given filter
 
           Possible values:
-          - all:                    All sleds
+          - commissioned:           All sleds that are currently part of the control plane cluster
           - discretionary:          Sleds that are eligible for discretionary services
           - in-service:             Sleds that are in service (even if they might not be eligible
             for discretionary services)

dev-tools/reconfigurator-cli/src/main.rs

@@ -559,7 +559,7 @@ fn cmd_sled_list(
         .to_planning_input_builder()
         .context("failed to generate planning input")?
         .build();
-    let rows = planning_input.all_sled_resources(SledFilter::All).map(
+    let rows = planning_input.all_sled_resources(SledFilter::Commissioned).map(
         |(sled_id, sled_resources)| Sled {
             id: sled_id,
             subnet: sled_resources.subnet.net().to_string(),
@@ -648,7 +648,7 @@ fn cmd_inventory_generate(
     // has no zones on it.
     let planning_input =
         sim.system.to_planning_input_builder().unwrap().build();
-    for sled_id in planning_input.all_sled_ids(SledFilter::All) {
+    for sled_id in planning_input.all_sled_ids(SledFilter::Commissioned) {
         builder
             .found_sled_omicron_zones(
                 "fake sled agent",
@@ -1077,7 +1077,7 @@ fn cmd_load(
         .context("generating planning input")?
         .build();
     for (sled_id, sled_details) in
-        loaded.planning_input.all_sleds(SledFilter::All)
+        loaded.planning_input.all_sleds(SledFilter::Commissioned)
     {
         if current_planning_input.sled_resources(&sled_id).is_some() {
             swriteln!(
@@ -1202,7 +1202,7 @@ fn cmd_file_contents(args: FileContentsArgs) -> anyhow::Result<Option<String>> {
     let mut s = String::new();
 
     for (sled_id, sled_resources) in
-        loaded.planning_input.all_sled_resources(SledFilter::All)
+        loaded.planning_input.all_sled_resources(SledFilter::Commissioned)
     {
         swriteln!(
             s,

nexus/db-queries/src/db/datastore/deployment.rs

@@ -1553,7 +1553,7 @@ mod tests {
         // Check the number of blueprint elements against our collection.
         assert_eq!(
             blueprint1.blueprint_zones.len(),
-            planning_input.all_sled_ids(SledFilter::All).count(),
+            planning_input.all_sled_ids(SledFilter::Commissioned).count(),
         );
         assert_eq!(
             blueprint1.blueprint_zones.len(),

nexus/db-queries/src/db/datastore/mod.rs

@@ -110,6 +110,8 @@ pub use probe::ProbeInfo;
 pub use rack::RackInit;
 pub use rack::SledUnderlayAllocationResult;
 pub use silo::Discoverability;
+pub use sled::SledTransition;
+pub use sled::TransitionError;
 pub use switch_port::SwitchPortSettingsCombinedResult;
 pub use virtual_provisioning_collection::StorageType;
 pub use volume::read_only_resources_associated_with_volume;