Change reporter text for better UX #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoix
approved these changes
Dec 22, 2022
|
Should we update /megalinter/reporters/GitlabCommentReporter.py as well? |
nvuillam
requested changes
Dec 22, 2022
ashokm
force-pushed
the
change_reporter_text
branch
from
454e55e
to
20216c1
Compare
ashokm
force-pushed
the
change_reporter_text
branch
from
20216c1
to
454719a
Compare
To prevent users seeing 'See errors details in' text even when their run is not in an error state, lets change this to 'See detailed report in'. Also removing the 'artifact' text in the message as there are use cases where artifacts are not published and the link takes the user to the build (and not artifacts) page.
ashokm
force-pushed
the
change_reporter_text
branch
from
454719a
to
cdf2c90
Compare
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent users seeing 'See errors details in' text even when their run is not in an error state, lets change this to 'See detailed report in'.
Also removing the 'artifact' text in the message as there are use cases where artifacts are not published and the link takes the user to the build (and not artifacts) page.