Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BASH_SHFMT error #267

Merged
merged 10 commits into from
Jan 18, 2021
Merged

Fix BASH_SHFMT error #267

merged 10 commits into from
Jan 18, 2021

Conversation

nvuillam
Copy link
Member

@nvuillam nvuillam commented Jan 18, 2021

Closes #266

  • fix shfmt error in python flavor
  • reactivate BASH_SHFMT and DOCKERFILE_HADOLINT for Mega-Linter own sources linting

@codecov-io
Copy link

codecov-io commented Jan 18, 2021

Codecov Report

Merging #267 (ef51edf) into master (2cabd48) will increase coverage by 1.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   85.77%   86.92%   +1.14%     
==========================================
  Files         111      111              
  Lines        2095     2095              
==========================================
+ Hits         1797     1821      +24     
+ Misses        298      274      -24     
Impacted Files Coverage Δ
megalinter/MegaLinter.py 88.54% <0.00%> (+0.34%) ⬆️
megalinter/reporters/UpdatedSourcesReporter.py 89.18% <0.00%> (+2.70%) ⬆️
...alinter/tests/test_megalinter/helpers/utilstest.py 99.11% <0.00%> (+9.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cabd48...ef51edf. Read the comment docs.

@nvuillam
Copy link
Member Author

Mega-Linter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ BASH bash-exec 8 2 0.28s
✅ BASH shellcheck 8 0 1.25s
⚠️ BASH shfmt 8 5 5 0.34s
✅ COPYPASTE jscpd yes no 2.44s
✅ CSS stylelint 1 0 0 1.12s
✅ DOCKERFILE dockerfilelint 1 0 0.26s
❌ DOCKERFILE hadolint 1 1 0.88s
✅ GIT git_diff yes no 0.02s
✅ JSON eslint-plugin-jsonc 17 0 0 2.85s
✅ JSON jsonlint 17 0 4.88s
✅ JSON v8r 17 0 8.54s
✅ MARKDOWN markdownlint 175 2 0 3.03s
✅ MARKDOWN markdown-link-check 175 0 74.78s
✅ MARKDOWN markdown-table-formatter 175 2 0 2.69s
✅ OPENAPI spectral 1 0 1.24s
✅ PYTHON black 123 0 0 31.16s
✅ PYTHON flake8 123 0 2.09s
✅ PYTHON isort 123 0 0 0.47s
✅ PYTHON pylint 123 0 14.68s
✅ SPELL cspell 433 0 38.96s
✅ SPELL misspell 298 7 0 0.24s
✅ XML xmllint 1 0 0.04s
❌ YAML v8r 33 1 23.34s
✅ YAML yamllint 87 0 12.86s

See errors details in artifact Mega-Linter reports on GitHub Action page

You could have the same capabilities but better runtime performances if you use a Mega-Linter flavor:

@nvuillam nvuillam marked this pull request as ready for review January 18, 2021 23:40
@nvuillam nvuillam merged commit 6e0b31b into master Jan 18, 2021
@nvuillam nvuillam deleted the fix_shfmt branch January 18, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python flavor image failing: FileNotFoundError: [Errno 2] No such file or directory: 'shfmt'
2 participants