Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to terraform_tflint about TERRAFORM_TFLINT_UNSECURED_ENV_VARIABLES #2706

Closed
wants to merge 1 commit into from
Closed

Add note to terraform_tflint about TERRAFORM_TFLINT_UNSECURED_ENV_VARIABLES #2706

wants to merge 1 commit into from

Conversation

ruzickap
Copy link
Contributor

Fixes #2699

Proposed Changes

  1. Add details about TERRAFORM_TFLINT_UNSECURED_ENV_VARIABLES to the terraform_tflint documentation.

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@ruzickap ruzickap requested a review from nvuillam as a code owner May 31, 2023 07:28
@ruzickap ruzickap temporarily deployed to dev May 31, 2023 10:58 — with GitHub Actions Inactive
@nvuillam
Copy link
Member

@ruzickap you got a typo ^^ ( or a new word to add in .cspell.json ^^ )

@ruzickap ruzickap temporarily deployed to dev May 31, 2023 17:38 — with GitHub Actions Inactive
@ruzickap ruzickap temporarily deployed to dev May 31, 2023 17:38 — with GitHub Actions Inactive
@@ -18,6 +18,8 @@ Set variable TERRAFORM_TFLINT_SECURED_ENV to `false` if you need `tflint --init`
- See [How to disable tflint rules in files](https://github.com/terraform-linters/tflint/blob/master/docs/guides/annotations.md){target=_blank}
- See [Index of problems detected by tflint](https://github.com/terraform-linters/tflint/tree/master/docs/rules#rules){target=_blank}

> If you are using the GitHub action please use the `TERRAFORM_TFLINT_UNSECURED_ENV_VARIABLES: GITHUB_TOKEN` to prevent plugin download issues
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruzickap this page is generated from terraform.megalinter-descriptor.yml, but it's ok, I'll merge it in one of my PRs then fix it then declare you as co-author :)

@nvuillam
Copy link
Member

Merged in #2708 with you as co-author :)

@nvuillam nvuillam closed this May 31, 2023
@ruzickap ruzickap deleted the improve-tflint-docs branch May 31, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tflint doesn't work in megalinter 7.0.x
2 participants