Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close #2038 BarSeries hit test issue fixed #2039

Conversation

belucha
Copy link
Contributor

@belucha belucha commented Sep 12, 2023

  • add demonstration code
  • fix the problem, by correctly setting the index of the ValidItemsIndexInversion Dictionary

Fixes #2038

Checklist

  • I have included examples or tests
  • I have updated the change log
  • I am listed in the CONTRIBUTORS file
  • I have cleaned up the commit history (use rebase and squash)

Changes proposed in this pull request:

None.

@oxyplot/admins

- add demonstration code
- fix the problem, by correctly setting the index of the
  ValidItemsIndexInversion Dictionary
@VisualMelon
Copy link
Contributor

Fix looks good to me!

Very boring, but bug examples should be in the ExampleLibrary.Issues class (and in this case marked closed because it is fixed): can you move it to Issues and add a SubTitle explaining the expected behaviour so that when we come back to in future we can be sure the issue hasn't returned.

add some hints and improve documentation
@belucha
Copy link
Contributor Author

belucha commented Sep 12, 2023

@VisualMelon thanks for the fast reply. I've made the changes as requested.

Regards Daniel

@VisualMelon
Copy link
Contributor

All looks good to me; won't merge just yet so that the other maintainers have an opportunity to look it over.

belucha added a commit to belucha/oxyplot that referenced this pull request Sep 13, 2023
Net7.0 only pre-release until oxyplot#2039 is merged into main package
@VisualMelon VisualMelon merged commit 515e4a0 into oxyplot:develop Sep 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BarSeriesBase: HitTest does not deliver the correct BarItem, when there are invalid items in Data
2 participants