Fix #4: Support timezones with non-hourly (non-integer) UTC offsets #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey James! Thanks for the PR. This looks pretty great. 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the correct start hour for all timezones even when the UTC offset isn’t a round number of hours.
Before this fix the wrong start hour (integer) was calculated when timezones involved a part-hour offset, causing the wrong current hour to be highlighted, and entire timezone rows to be misaligned. This bug #4 impacted
tzfor more than a billion people. For example when working with India Standard Time (IST = UTC+05:30, known as “Asia/Calcutta” intkuchiki/go-timezone) at UTC=12:45,tzcould align India with 5 am as the current displayed hour but it should have been 6 am.This fix uses the same approach as the emojis, which were displayed correctly.