-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dollar as valid identifier char #29
Conversation
Code Climate has analyzed commit e467851 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Hi @moisespsena, thank you for the PR.
uGO is used in production a lot, and we cannot introduce anything easily, especially syntax changes. So making it optional until it is fully implemented and production-ready is the only choice for now. If you want to go ahead, please create an "exp" package in the project workspace and define a constant like Additional requirements about the PR:
|
Please open a new PR if you'd like to continue. |
This PR will allow the use of the dollar in identifiers, such as JavaScript.
My intention is to create a template language with UGO, and define the dollar prefixed variables will make it more intuitive.