Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running the scale command with any argument gives an error #30

Closed
amanharwara opened this issue Sep 19, 2020 · 4 comments
Closed

Running the scale command with any argument gives an error #30

amanharwara opened this issue Sep 19, 2020 · 4 comments

Comments

@amanharwara
Copy link

Command line output:

❯ rustmt scale D Locrian
error: Found argument 'D' which wasn't expected, or isn't valid in this context
USAGE:
    rustmt.exe scale <SUBCOMMAND>

For more information try --help

Same thing happens when using something like rustmt scale C Minor

Installed on a Windows 10 machine using cargo install.

@ozankasikci
Copy link
Owner

ozankasikci commented Sep 19, 2020

Hi @amanharwara, thanks for reporting the issue!

I tried and indeed it gives an error. @XBagon this seems to be related to your latest PR regarding CLI refactoring, do you have any idea what is wrong here?

I will revert the changes for the time being.

@ozankasikci
Copy link
Owner

@amanharwara reverted the CLI changes, if you pull the latest code, it should work now.

@amanharwara
Copy link
Author

Works correctly now. Thanks!

@XBagon
Copy link
Contributor

XBagon commented Sep 26, 2020

I really missed writing about this change. It's expecting the subcommand notes or list, help should clear this up.

I couldn't keep the current "API", cause strucopt doesn't allow it that easily, and I thought for good reason. The API would be a lot cleaner that way removing a parameter that can be a string argument or a subcommand. Really forgot to tell you about this or change the README, sorry!

I don't mind the reversion for the moment though, as I hadn't time to continue to work at it and add the missing features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants