Issue-51: Prints Process Logs in RuntimeException Message

[ashok2ashok]

This resolves the issue: kstyrc#51

While resolving logs at the process level is preferred as specified in the pull-request: kstyrc#113 - this fix takes a much more conservative approach and prints the redis process logs only in case of an error/exception when the server startup pattern is not found. That way we do not need to worry about logs in case of successful redis server starts.

Removed @override as they are not needed when implementing interfaces.

Before this fix:

java.lang.RuntimeException: Can't start redis server. Check logs for details.
	at redis.embedded.AbstractRedisInstance.awaitRedisServerReady(AbstractRedisInstance.java:67)
	at redis.embedded.AbstractRedisInstance.start(AbstractRedisInstance.java:29)
	at redis.embedded.RedisServer.start(RedisServer.java:9)

After this fix error log:

java.lang.RuntimeException: Can't start redis server. Check logs for details. Redis process log: 
[63038] 12 Mar 14:16:06.220 # Creating Server TCP listening socket 127.0.0.1:6379: bind: Address already in use
	at redis.embedded.AbstractRedisInstance.awaitRedisServerReady(AbstractRedisInstance.java:60)
	at redis.embedded.AbstractRedisInstance.start(AbstractRedisInstance.java:36)
	at redis.embedded.RedisServer.start(RedisServer.java:9)

Without the above fix, the workaround the devs need to write is not perfect like below. The exception message e.getMessage() can't be checked for exact cause. We can only guess at it:

//    Keep for embedded Redis config testing
    public static void main(String... args) throws Exception {
        int port = 6379;
        RedisServer redisServer = null;
        try{
            redisServer = new RedisServer(port);
            redisServer.start();
        } catch(RuntimeException e) {
            if (e.getMessage().contains("Can't start redis server")) {
                int freePort = SocketUtils.findAvailableTcpPort();
                LOGGER.warn("{} Port already in use. Changing port to {}", port, freePort);
                redisServer = new RedisServer(freePort);
                redisServer.start();
            }
        }
    }

[ashok2ashok]

@robertotru - Looks like Java 8 installation in Travis is failing. It's expecting a feature between 9 to 15, but the script has 8. Please correct the build configs:

travis_fold:start:install_jdk
�[0K�[33;1mInstalling oraclejdk8�[0m
$ export JAVA_HOME=~/oraclejdk8
$ export PATH="$JAVA_HOME/bin:$PATH"
$ ~/bin/install-jdk.sh --target "/home/travis/oraclejdk8" --workspace "/home/travis/.cache/install-jdk" --feature "8" --license "BCL"
Ignoring license option: BCL -- using GPLv2+CE by default
install-jdk.sh 2020-01-14
Expected feature release number in range of 9 to 15, but got: 8
�[31;1mThe command "~/bin/install-jdk.sh --target "/home/travis/oraclejdk8" --workspace "/home/travis/.cache/install-jdk" --feature "8" --license "BCL"" failed and exited with 3 during .�[0m

Your build has been stopped.

Ref:

• https://travis-ci.org/github/ozimov/embedded-redis/builds/661675375?utm_medium=notification&utm_source=github_status
• https://api.travis-ci.org/v3/job/661675376/log.txt

[ashok2ashok]

@robertotru - I fixed the .travis.yml build script to:

• Use trusty distribution as the default xenial has issues with oraclejdk8
• Removed the jpm4j package manager as it's no longer functional
• Removed sudo: false as it's deprecated and no longer needed.

The build is successful now and is ready to be merged.

[lploom]

Can we get a release please?