Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature fix for #44 : Skip every second row support #109

Closed
wants to merge 2 commits into from

Conversation

itsjwala
Copy link
Contributor

@itsjwala itsjwala commented Nov 2, 2019

By specifying jumpReads(readEvery,skipEvery) in options we can read particular rows, and skip rows after that read, so on and so forth, until limit is reached (if specified or end of the sheet)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 94.189% when pulling 8bee43c on jigarWala:#44 into a98e449 on ozlerhakan:master.

@ozlerhakan
Copy link
Owner

this gives us some performans issue in the future, I have seen @jigarWala , let's close this pr and we can figure out other options to make it more robust way

@ozlerhakan ozlerhakan closed this Nov 11, 2019
@itsjwala
Copy link
Contributor Author

okay whatever suits you @ozlerhakan, Actually in this PR I had update #32 code too. could you have a look ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants