Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed @ExcelRow returning offset index on missing line #114

Merged
merged 2 commits into from
Dec 7, 2019
Merged

Fixed @ExcelRow returning offset index on missing line #114

merged 2 commits into from
Dec 7, 2019

Conversation

breucode
Copy link
Contributor

@breucode breucode commented Dec 4, 2019

Fixes #111

@coveralls
Copy link

coveralls commented Dec 4, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 92.448% when pulling de23216 on breucode:master into f8f0a18 on ozlerhakan:master.

@breucode breucode mentioned this pull request Dec 6, 2019
Merged
@ozlerhakan
Copy link
Owner

could you also add test cases for xls files @breucode ?

@breucode
Copy link
Contributor Author

breucode commented Dec 6, 2019

Done :)

@ozlerhakan ozlerhakan merged commit de23216 into ozlerhakan:master Dec 7, 2019
@ozlerhakan
Copy link
Owner

merged @breucode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2.2.0 Regression: @ExcelRow handling has changed for empty rows
3 participants
@breucode @coveralls @ozlerhakan