Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#134 add closing for HSSFWorkbook #136

Closed
wants to merge 1 commit into from
Closed

#134 add closing for HSSFWorkbook #136

wants to merge 1 commit into from

Conversation

vaa25
Copy link
Contributor

@vaa25 vaa25 commented Feb 10, 2020 •
edited
Loading

resolves #134

@vaa25 vaa25 changed the title #134 add closing for HSSFWorkbook add closing for HSSFWorkbook Feb 10, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 91.859% when pulling 48720ad on vaa25:134-Filehandle-is-left-open-on-XLS into 12283d9 on ozlerhakan:2.6.0.

@vaa25 vaa25 changed the title add closing for HSSFWorkbook #134 add closing for HSSFWorkbook Feb 10, 2020
@ozlerhakan
Copy link
Owner

thanks @vaa25 , I will change a bit of the code in my local to better point out, so just closing this pr

@ozlerhakan ozlerhakan closed this Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaa25 @coveralls @ozlerhakan