Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This commit addresses the following issues: #147

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

chinmay1994
Copy link
Contributor

  1. Fix issue where row and column is not sent to the casting interface.
  2. Fix issue where the setValue() method is called twice.

1. Fix issue where row and column is not sent to the casting interface.
2. Fix issue where the setValue() method is called twice.
@ozlerhakan
Copy link
Owner

Oh, hey @chinmay1994 , I am just releasing the new version with the fix for your issue 😅

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.0% when pulling c5f15f3 on chinmay1994:fix/issue_146 into 12283d9 on ozlerhakan:master.

@chinmay1994
Copy link
Contributor Author

chinmay1994 commented Apr 21, 2020

Oh, hey @chinmay1994 , I am just releasing the new version with the fix for your issue 😅

Haha, great! Does it fix both the issues?

@ozlerhakan
Copy link
Owner

I will add your changes as well 👏

@chinmay1994
Copy link
Contributor Author

Thank you @ozlerhakan 😊

@ozlerhakan ozlerhakan merged commit 3961065 into ozlerhakan:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants