Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple level headers #181

Merged
merged 4 commits into from
Nov 14, 2020
Merged

Support multiple level headers #181

merged 4 commits into from
Nov 14, 2020

Conversation

thuydx55
Copy link

@thuydx55 thuydx55 commented Nov 6, 2020

Consider you have a table like below:

┌─────┬────────────────────────────────────────────────────┬───────────────────────────────────────────────┐
│ No. │                 Person Information                 │            Credit Card Information            │
│     ├───────────┬─────┬────────────┬──────────┬──────────┼────────────┬───────────────┬──────────────────┤
│     │   Name    │ Age │     City   │  State   │ Zip Code │  Card Type │ Last 4 Digits │ Expiration Date  │
├─────┼───────────┼─────┼────────────┼──────────┼──────────┼────────────┼───────────────┼──────────────────┤
│  1  │ John Doe  │  21 │ Vienna     │ Virginia │   22349  │ VISA       │      1234     │     Jan─21       │
│  2  │ Jane Doe  │  28 │ Greenbelt  │ Maryland │   20993  │ MasterCard │      2345     │     Jun─22       │
│  3  │ Paul Ryan │  19 │ Alexandria │ Virginia │   22312  │ JCB        │      4567     │     Oct─24       │
└─────┴───────────┴─────┴────────────┴──────────┴──────────┴────────────┴───────────────┴──────────────────┘

This PR handle multi-level headers and map to object in the same structure.

Tests added.

@ozlerhakan
Copy link
Owner

Hi @thuydx55 ,

Thank you for the chances!

Do we need to add new feature section on the readme file? you may update https://github.com/ozlerhakan/poiji#feature-6 instead, wdyt?

@thuydx55
Copy link
Author

thuydx55 commented Nov 6, 2020

@ozlerhakan Agreed with you. I've just updated README, merged my example to feature 6.

@ozlerhakan
Copy link
Owner

great! this will be in 3.0.2 :)

@ozlerhakan ozlerhakan merged commit cffd09e into ozlerhakan:master Nov 14, 2020
@ozlerhakan
Copy link
Owner

merged! @thuydx55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants