Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacto(cors): use manageHeaders for CORS headers #16

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

p-j
Copy link
Owner

@p-j p-j commented Nov 25, 2020

  • @p-j/eapi-middleware-headers
    • export utility functions to handle header values
    • ignore header with empty values
  • @p-j/eapi-middleware-cors
    • use utility functions to handle CORS headers
    • update tests accordingly

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2020

🦋 Changeset detected

Latest commit: 0b9192c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@p-j/eapi-middleware-cors Minor
@p-j/eapi-middleware-headers Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #16 (0b9192c) into main (c1965d6) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   98.71%   98.67%   -0.05%     
==========================================
  Files           7        7              
  Lines         156      151       -5     
  Branches       62       62              
==========================================
- Hits          154      149       -5     
  Misses          2        2              
Impacted Files Coverage Δ
packages/eapi-middleware-cors/src/withCors.ts 100.00% <100.00%> (ø)
...ackages/eapi-middleware-headers/src/withHeaders.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd7ec0...0b9192c. Read the comment docs.

@p-j p-j merged commit 3774329 into main Nov 25, 2020
@p-j p-j deleted the refacto/cors-with-headers branch November 25, 2020 17:32
@github-actions github-actions bot mentioned this pull request Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant