Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose finding marker to API #5

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Expose finding marker to API #5

merged 2 commits into from
Feb 20, 2020

Conversation

nairaner
Copy link

In my use case I need to be able to find marker which is at the center of the screen, so i exposed previously private getViewFromTap

Copy link
Owner

@p-lr p-lr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Instead of making getViewFromTap public, could you make it internal instead?
After that, +1 to merge.

@p-lr p-lr merged commit 3620498 into p-lr:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants