Subclass OAuth2ImplicitGrant for a non-standard case #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles APIs that return token and other info in the query instead of the fragment.
p2
requested changes
May 4, 2018
There was a problem hiding this comment.
Awesome, thanks! Can you fix the comment and then use tabs instead of spaces to keep consistent with the rest of the project? Also, see https://github.com/p2/OAuth2/blob/master/CONTRIBUTING.md → add your name!
| override open func handleRedirectURL(_ redirect: URL) { | ||
| logger?.debug("OAuth2", msg: "Handling redirect URL \(redirect.description)") | ||
| do { | ||
| // token should be in the URL fragment |
|
Spaces, ack, what was I thinking! Shows what I get for making changes in the web interface. Fixes applied! |
|
Haha, you, who wants spaces! ;) Thanks, looks good to me though haven't tested, accepting! |
MaximeLM
pushed a commit
to MaximeLM/OAuth2
that referenced
this pull request
Aug 23, 2018
…2#262) Handles APIs that return token and other info in the query instead of the fragment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles APIs that return token and other info in the query instead of the fragment.