Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve error detection and logging #29

Merged
merged 4 commits into from
May 10, 2023
Merged

feat: improve error detection and logging #29

merged 4 commits into from
May 10, 2023

Conversation

SpontaneousOverthrow
Copy link
Contributor

selfuryon
selfuryon previously approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@selfuryon selfuryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@martelev can you check it too pls?

@SpontaneousOverthrow SpontaneousOverthrow marked this pull request as draft May 9, 2023 23:31
martelev
martelev reviewed May 10, 2023
View reviewed changes
cmd/combine/helpers.go Outdated Show resolved Hide resolved
martelev
martelev previously approved these changes May 10, 2023
View reviewed changes
@SpontaneousOverthrow SpontaneousOverthrow marked this pull request as ready for review May 10, 2023 09:02
selfuryon
selfuryon approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@selfuryon selfuryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SpontaneousOverthrow SpontaneousOverthrow merged commit 359dab6 into main May 10, 2023
@SpontaneousOverthrow SpontaneousOverthrow deleted the refactoring_logging branch May 10, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selfuryon selfuryon selfuryon approved these changes

@martelev martelev martelev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpontaneousOverthrow @selfuryon @martelev