Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add release ci #30

Merged
merged 3 commits into from
May 11, 2023
Merged

feat: add release ci #30

merged 3 commits into from
May 11, 2023

Conversation

SpontaneousOverthrow
Copy link
Contributor

@SpontaneousOverthrow SpontaneousOverthrow commented May 10, 2023 •
edited
Loading

Adding release ci:

  • building binaries for linux,darwin
  • publish to github release page

@selfuryon
Copy link
Collaborator

Add description to this PR, please

selfuryon
selfuryon requested changes May 10, 2023
View reviewed changes
.github/workflows/release.yaml Outdated Show resolved Hide resolved
@SpontaneousOverthrow SpontaneousOverthrow marked this pull request as draft May 10, 2023 18:06
@SpontaneousOverthrow
Copy link
Contributor Author

Ok, I have added version and cmd to check it, version is updated using build flags.
ChangeLog is autogenerated based on commits and branches.

I can only compile dkc for darwin amd64 and linux amd64, as cross-architecture compiling is quite challenging. Do you have any suggestions?

Also, i don't like using cache restore twice in the release job.

@SpontaneousOverthrow SpontaneousOverthrow marked this pull request as ready for review May 11, 2023 07:59
selfuryon
selfuryon approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@selfuryon selfuryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SpontaneousOverthrow SpontaneousOverthrow merged commit fa18da7 into main May 11, 2023
@SpontaneousOverthrow SpontaneousOverthrow deleted the ci_improvements_releases branch May 11, 2023 12:23
@SpontaneousOverthrow SpontaneousOverthrow mentioned this pull request May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selfuryon selfuryon selfuryon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SpontaneousOverthrow @selfuryon