Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Update Combine logic #6

Merged
merged 9 commits into from
Mar 23, 2023
Merged

Feat: Update Combine logic #6

merged 9 commits into from
Mar 23, 2023

Conversation

SpontaneousOverthrow
Copy link
Contributor

No description provided.

@SpontaneousOverthrow SpontaneousOverthrow changed the title Feat: Update combain logic Feat: Update Combaine logic Mar 20, 2023
@SpontaneousOverthrow SpontaneousOverthrow changed the title Feat: Update Combaine logic Feat: Update Combine logic Mar 20, 2023
selfuryon
selfuryon reviewed Mar 20, 2023
View reviewed changes
cmd/combine/stores.go Outdated Show resolved Hide resolved
selfuryon
selfuryon approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@selfuryon selfuryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add verification function to recover function.

selfuryon
selfuryon approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@selfuryon selfuryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/split/run.go Outdated Show resolved Hide resolved
@SpontaneousOverthrow SpontaneousOverthrow merged commit 60fc84b into feat/update Mar 23, 2023
@SpontaneousOverthrow SpontaneousOverthrow deleted the feat/combine branch March 23, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selfuryon selfuryon selfuryon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SpontaneousOverthrow @selfuryon