Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge typing, EventEmitter support #136

Merged
merged 52 commits into from
Feb 9, 2017
Merged

Merge typing, EventEmitter support #136

merged 52 commits into from
Feb 9, 2017

Conversation

LivInTheLookingGlass
Copy link
Collaborator

@codecov-io
Copy link

codecov-io commented Feb 8, 2017

Codecov Report

Merging #136 into develop will increase coverage by 1.61%.

@@             Coverage Diff             @@
##           develop     #136      +/-   ##
===========================================
+ Coverage    69.76%   71.37%   +1.61%     
===========================================
  Files           19       19              
  Lines         2758     2791      +33     
  Branches       434      429       -5     
===========================================
+ Hits          1924     1992      +68     
+ Misses         794      759      -35     
  Partials        40       40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3268383...b22fa32. Read the comment docs.

@LivInTheLookingGlass
Copy link
Collaborator Author

Note, the tutorials will need to be updated

@LivInTheLookingGlass
Copy link
Collaborator Author

Getting some failures on Windows, but I'm going to take the position that I am not responsible for bugs in the ssl module. I should probably be mocking this at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants