Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump p2panda-rs #129

Merged
merged 2 commits into from
May 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Improve `Signal` efficiency in `ServiceManager` [#95](https://github.com/p2panda/aquadoggo/pull/95)
- `EntryStore` improvements [#123](https://github.com/p2panda/aquadoggo/pull/123)
- Improvements for log and entry table layout [#124](https://github.com/p2panda/aquadoggo/issues/122)
- Update `StorageProvider` API after `p2panda-rs` changes [129](https://github.com/p2panda/aquadoggo/pull/129)

## [0.2.0]

Expand Down
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 2 additions & 6 deletions aquadoggo/src/db/stores/entry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ impl EntryStore<StorageEntry> for SqlStorage {
/// It is worth noting that this method doesn't check if the certificate pool
/// is complete, it only returns entries which are part of the pool and found
/// in storage. If an entry was not stored, then the pool may be incomplete.
async fn get_all_skiplink_entries_for_entry(
async fn get_certificate_pool(
&self,
author: &Author,
log_id: &LogId,
Expand Down Expand Up @@ -648,11 +648,7 @@ mod tests {
let author = Author::try_from(*key_pair.public_key()).unwrap();

let entries = storage_provider
.get_all_skiplink_entries_for_entry(
&author,
&LogId::default(),
&SeqNum::new(20).unwrap(),
)
.get_certificate_pool(&author, &LogId::default(), &SeqNum::new(20).unwrap())
.await
.unwrap();

Expand Down
2 changes: 1 addition & 1 deletion aquadoggo/src/errors.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// SPDX-License-Identifier: AGPL-3.0-or-later

/// A specialized result type for the storage provider.
pub type StorageProviderResult<T> = anyhow::Result<T, Box<dyn std::error::Error>>;
pub type StorageProviderResult<T> = anyhow::Result<T, Box<dyn std::error::Error + Sync + Send>>;